Skip to content

Conversation

jovial
Copy link

@jovial jovial commented Oct 2, 2024

No description provided.

No functional change as this wasn't actually in use.
This will discard any pending messages immediately when the socket is
closed. The default is to wait forever for any pending messages which
can cause the the daemon to hang on shutdown.

See: http://api.zeromq.org/4-2:zmq-setsockopt
Previously, if data was None, we'd not send a reply. This can lead
to clients hanging when they are expecting a reply.
Symptom was that eswitchd would become unresponsive after some time.
The following error was observed:

  GetVnics failed - [Errno 24] Too many open files: OSError: [Errno 24] Too many open files

This was tracked down to forgetting to call close on IPRoute objects
as per the documentation. See:

- https://docs.pyroute2.org/iproute.html
- svinota/pyroute2#631
@jovial jovial changed the title Various bug fixes [2023.1] Various bug fixes Oct 2, 2024
@jovial jovial requested a review from tomclark0 October 2, 2024 16:40
@jovial jovial merged commit 6065fdb into stackhpc/2023.1 Oct 3, 2024
@jovial jovial deleted the bugfix/2023.1 branch October 3, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant